-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semantic model: Remove duplicate non-semantic tags in Item component #2095
Conversation
Signed-off-by: David Kesl <[email protected]>
Job #1164: Bundle Size — 15.78MiB (+0.11%).
Metrics (7 changes)
Total size by type (3 changes)
View job #1164 report View Davek145:model-item-tag-fix branch activity |
Can you please provide a screenshot where you see those duplicate tags? |
I am a bit hesitate here, because on one hand they are duplicate, but only if edit mode is active. If it is not active, you won't see the tags. It is the semantic model, one could argue that you don't need to see the normal tags ... |
It just looked weird to me. But you are right that it is like this only when in edit mode. |
Agreed! |
Signed-off-by: David Kesl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes introduced into #2087 in combination with #2093 create duplicity in showing non-semantic tags in the model page (component/model/item-details.vue).
Non-semantic tags are displayed both in the Item and when edit mode is enabled, in the accordion tag input in item-form.